[U-Boot] [PATCH] arm, post: add missing post_time_ms for arm

Heiko Schocher hs at denx.de
Mon Nov 21 15:09:38 CET 2011


Hello Holger,


added Prafulla Wadaskar to cc ...

Holger Brunck wrote:
> Hi Heiko,
> 
> On 09/15/2011 07:34 AM, Heiko Schocher wrote:
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>> ---
>>  post/post.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/post/post.c b/post/post.c
>> index 6c59f91..0bfca75 100644
>> --- a/post/post.c
>> +++ b/post/post.c
>> @@ -488,7 +488,7 @@ void post_reloc(void)
>>   */
>>  unsigned long post_time_ms(unsigned long base)
>>  {
>> -#ifdef CONFIG_PPC
>> +#if defined(CONFIG_PPC) || defined(CONFIG_ARM)
>>  	return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ))
>>  		- base;
>>  #else
> 
> this commit breaks post test support for our keymile arm boards:

:-(

I am sure I tried a "MAKEALL arm" ... Hmm.. how did the post support
worked for you before this patch? You should have seen this warning message:

#warning "Not implemented yet"

or?

>> make km_kirkwood
> [...]
> post/libpost.o: In function `post_time_ms':
> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_ticks'
> /daten/ws_root/hbu/u-boot-km.git/post/post.c:504: undefined reference to `get_tbclk'
> 
> So it seems that the kirkwood code has no implementation for these functions.
> Any idea how to fix this?

We must implement it ... Prafulla, can you comment this?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list