[U-Boot] [PATCH] tegra2: mmc: Enable card-detect for all interfaces.

Stephen Warren swarren at nvidia.com
Mon Nov 21 18:09:23 CET 2011


On 11/21/2011 01:35 AM, Thierry Reding wrote:
> This commit drops the interface check for card-detection and leaves it
> up to the board whether or not a card-detect GPIO is connected. Also,
> the version field of struct mmc is only valid after the slot has been
> probed successfully, so depending on that information sort of defeats
> the purpose of card-detection.
> 
> Signed-off-by: Thierry Reding <thierry.reding at avionic-design.de>

Acked-by: Stephen Warren <swarren at nvidia.com>

BTW, in your earlier patch where you added a call to board_mmc_getcd()
to mmc_init(), do you also need to modify drivers/mmc/fsl_esdhc.c's
esdhc_init(), since the cd function has already been called?

BTW, you need to CC the MMC maintainers on these patches, or they
probably won't see them and they won't get applied. See
http://www.denx.de/wiki/U-Boot/Custodians.

-- 
nvpublic


More information about the U-Boot mailing list