[U-Boot] [RFC PATCH v2 03/12] arm, da850: Move the definitions of pinmux configurations to the arch tree

Christian Riesch christian.riesch at omicron.at
Tue Nov 22 08:26:22 CET 2011


Hello Mike,
Thank you for your comments.

On Mon, Nov 21, 2011 at 8:03 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 21 November 2011 11:33:38 Christian Riesch wrote:
>> --- /dev/null
>> +++ b/arch/arm/include/asm/arch-davinci/da850_pinmux.h
>>
>> +const struct pinmux_config spi1_pins[] = {
>> +     { pinmux(5), 1, 1 },
>> +     { pinmux(5), 1, 2 },
>> +     { pinmux(5), 1, 4 },
>> +     { pinmux(5), 1, 5 }
>> +};
>
> variable storage should not be in headers.  why can't this be in a C file ?

Ok, I'll move them to a C file.
Regards, Christian


More information about the U-Boot mailing list