[U-Boot] [PATCH] powerpc/85xx: clean up and document the QE/FMAN microcode macros

[Kumar Gala]

On Nov 8, 2011, at 5:40 PM, Timur Tabi wrote:

> Several macros are used to identify and locate the microcode binary image
> that U-boot needs to upload to the QE or Fman.  Both the QE and the Fman
> use the QE Firmware binary format to package their respective microcode data,
> which is why the same macros are used for both.  A given SOC will only have
> a QE or an Fman, so this is safe.
> 
> Unfortunately, the current macro definition and usage has inconsistencies.
> For example, CONFIG_SYS_FMAN_FW_ADDR was used to define the address of Fman
> firmware in NOR flash, but CONFIG_SYS_QE_FW_IN_NAND contains the address
> of NAND.  There's no way to know by looking at a variable how it's supposed
> to be used.
> 
> In the future, the code which uploads QE firmware and Fman firmware will
> be merged.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> README                              |   38 +++++++++++++++++++++++++++++++++++
> arch/powerpc/cpu/mpc85xx/cpu_init.c |   12 +++++-----
> arch/powerpc/cpu/mpc85xx/fdt.c      |    2 +-
> drivers/net/fm/fm.c                 |   32 ++++++++++++++--------------
> drivers/qe/qe.c                     |    4 +-
> include/configs/MPC8569MDS.h        |    3 +-
> include/configs/P1023RDS.h          |   10 +++++---
> include/configs/P2041RDB.h          |   13 +++++++----
> include/configs/corenet_ds.h        |   16 +++++++++-----
> include/configs/p1_p2_rdb_pc.h      |    5 ++-
> 10 files changed, 92 insertions(+), 43 deletions(-)

Can your respin against current upstream HEAD.  For some reason this doesn't apply cleanly there.

- k