[U-Boot] [PATCH V2 4/6] i.mx: serial_mxc: add the i.mx6q support

[Jason Hui]

On Mon, Nov 21, 2011 at 10:51 PM, Stefano Babic <sbabic at denx.de> wrote:
> On 18/11/2011 08:11, Jason Liu wrote:
>> Signed-off-by: Jason Liu <jason.hui at linaro.org>
>> Cc: Stefano Babic <sbabic at denx.de>
>> ---
>> v2: Cc Stefano
>> ---
>>  drivers/serial/serial_mxc.c |   10 +++++++---
>>  1 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/serial/serial_mxc.c b/drivers/serial/serial_mxc.c
>> index dcb4bd1..7d0f288 100644
>> --- a/drivers/serial/serial_mxc.c
>> +++ b/drivers/serial/serial_mxc.c
>> @@ -47,14 +47,18 @@
>>  #elif defined(CONFIG_SYS_MX27_UART6)
>>  #define UART_PHYS 0x1001c000
>>  #elif defined(CONFIG_SYS_MX35_UART1) || defined(CONFIG_SYS_MX51_UART1) || \
>> -     defined(CONFIG_SYS_MX53_UART1)
>> +     defined(CONFIG_SYS_MX53_UART1) || defined(CONFIG_MX6Q_UART1)
>>  #define UART_PHYS UART1_BASE_ADDR
>>  #elif defined(CONFIG_SYS_MX35_UART2) || defined(CONFIG_SYS_MX51_UART2) || \
>> -     defined(CONFIG_SYS_MX53_UART2)
>> +     defined(CONFIG_SYS_MX53_UART2) || defined(CONFIG_MX6Q_UART2)
>>  #define UART_PHYS UART2_BASE_ADDR
>>  #elif defined(CONFIG_SYS_MX35_UART3) || defined(CONFIG_SYS_MX51_UART3) || \
>> -     defined(CONFIG_SYS_MX53_UART3)
>> +     defined(CONFIG_SYS_MX53_UART3) || defined(CONFIG_MX6Q_UART3)
>>  #define UART_PHYS UART3_BASE_ADDR
>> +#elif defined(CONFIG_MX6Q_UART4)
>> +#define UART_PHYS UART4_BASE_ADDR
>> +#elif defined(CONFIG_MX6Q_UART5)
>> +#define UART_PHYS UART5_BASE_ADDR
>>  #else
>>  #error "define CONFIG_SYS_MXxx_UARTx to use the MXC UART driver"
>>  #endif
>
> This is not a comment of your patch, but I cannot avoid to note how much
> crap in this file. And we have not yet added all possible values for
> each SOC, only the values necessary to build the actual boards.
>
> The worst thing is that we do not need all this stuff. We set a lot of
> #ifdef only to set the UART base address, and we really ignore (because
> unneeded) the CONFIG_SYS_*_UART_*. It should be really better to define
> the base address in the board configuration file, as we already do for
> other drivers (USB with ehci base address, SD,..). Maybe with a
> MXC_UART_BASE_ADDRESS, and we can get rid of all this bad stuff.

Yes, fully agree.

>
> I will prepare a patch...

Waiting for your patch.

>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
> =====================================================================
>