[U-Boot] [RFC PATCH v2 12/12] arm, davinci: Add support for generating AIS images to the Makefile

[Mike Frysinger]

On Tuesday 22 November 2011 02:30:59 Christian Riesch wrote:
> Hello Mike,
> Thank you for your comments.
> 
> On Mon, Nov 21, 2011 at 8:09 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> > On Monday 21 November 2011 11:33:47 Christian Riesch wrote:
> >> --- a/Makefile
> >> +++ b/Makefile
> >> 
> >> +$(obj)u-boot.ais:       $(obj)spl/u-boot-spl.bin $(obj)u-boot.bin
> >> +             $(obj)tools/mkimage -s -n /dev/null -T aisimage \
> >> +             -e $(CONFIG_SPL_TEXT_BASE) -d $(obj)spl/u-boot-spl.bin \
> >> +             $(obj)spl/u-boot-spl.ais
> >> +             $(OBJCOPY) ${OBJCFLAGS} -I binary --pad-to=$(PAD_TO) -O
> >> binary $(obj)spl/u-boot-spl.ais $(obj)spl/u-boot-spl-pad.ais +        
> >>       cat $(obj)spl/u-boot-spl-pad.ais $(obj)u-boot.bin >
> >> $(obj)u-boot.ais +            rm $(obj)spl/u-boot-spl.ais
> >> +             rm $(obj)spl/u-boot-spl-pad.ais
> >> +
> > 
> > can't this live in arch/arm/.../config.mk somewhere ?
> 
> I guess it could. I placed it in Makefile since there are already a
> lot of similar targets there, like $(obj)u-boot.kwb, $(obj)u-boot.imx,
> $(obj)u-boot.ubl...

we need to clean this up.  if moving the target to a cpu config.mk doesn't 
work, then we can leave it alone for now until we generally clean this cruft 
up.

> >> --- /dev/null
> >> +++ b/board/davinci/da8xxevm/config.mk
> >> 
> >> +# required for SPI flash SPL
> >> +#
> >> +
> >> +PAD_TO       := 32768
> > 
> > "PAD_TO" is way too generic a name.  this should also be a CONFIG_XXX
> > define in the board config header rather than using config.mk.
> 
> Ok. I'll find a different name. I used $(PAD_TO) since the
> $(obj)u-boot.ubl target in Makefile already uses this name.

we should fix that too ;)
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111122/f4282827/attachment.pgp>