[U-Boot] [PATCH 2/2] ARM: omap3: add support to Technexion twister board

[Wolfgang Denk]

Dear Stefano Babic,

In message <1322040416-11751-3-git-send-email-sbabic at denx.de> you wrote:
> The twister board is a development board using
> the TAM3517 SOM.
> 
> Support for NAND, 2 Ethernet (EMAC and SMC911),
> USB (EHCI_OMAP).
> 
> Signed-off-by: Stefano Babic <sbabic at denx.de>
> CC: Tapani Utrianen <tapani at technexion.com>
> CC: Tom Rini <tom.rini at gmail.com>
> CC: Sandeep Paulraj <s-paulraj at ti.com>
...

> +/*
> + * Initializes on-chip ethernet controllers.
> + * to override, implement board_eth_init()
> + */
> +int board_eth_init(bd_t *bis)

What exactly is the meaning of the above comment?

> +#if defined(CONFIG_DRIVER_TI_EMAC)
> +	davinci_emac_initialize();
> +#endif

We always want this, don't we?


> +#define V_PROMPT			"twister => "
> +#define CONFIG_SYS_PROMPT		V_PROMPT

What is this V_PROMPT thing needed for? Please scrap it.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Always try to do things in chronological order; it's  less  confusing
that way.