[U-Boot] [PATCH 2/4] nds32/ag102: add ag102 soc support

Mike Frysinger vapier at gentoo.org
Wed Nov 23 20:36:09 CET 2011


On Tuesday 22 November 2011 21:16:50 Macpaul Lin wrote:
> 2011/11/19 Mike Frysinger <vapier at gentoo.org>
> > > +.globl       turnoff_watchdog
> > > +turnoff_watchdog:
> > > +
> > 
> > can't this be C code ?
> 
> This is because after reset, the watchdog might be enabled if there is
> another boot loader has ran before u-boot.
> If the other boot loader enabled watchdog but didn't stop it,
> it might cause u-boot to be reset during assembly initialization phase.
> So we need to disable watchdog here.

my point is, why can't turnoff_watchdog() be written in C ?  why does this func 
need to be written in assembly ?

looking at the start.S, seems like there's a bit of logic there that should be 
in C and not a lot of asm.  *shrug* too late now i guess.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111123/323b88a4/attachment.pgp>


More information about the U-Boot mailing list