[U-Boot] [PATCH v2] [cosmetic], i2c: Codingstyle cleanup for i2c evb64260 board driver

Wolfgang Denk wd at denx.de
Wed Nov 23 21:21:44 CET 2011


Dear Heiko Schocher,

In message <1321523716-31374-1-git-send-email-hs at denx.de> you wrote:
> There are some magic constants in this drivers, which I cannot
> fixup ... Eran, can you help here?
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>
> Cc: Eran Man <eran at nbase.co.il>
> ---
> - changes for v2:
>   - corrected some typos in v1 patch

Please be careful when chosing the Subject. Yours results in this
commit message:

	, i2c: Codingstyle cleanup ...

The leading ", " is probably unintended.

[Fixed when pulling that patch].

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A little retrospection shows that although many fine, useful software
systems have been  designed  by  committees  and  built  as  part  of
multipart  projects, those software systems that have excited passio-
nate fans are those that are the products of one or a  few  designing
minds,  great  designers.  Consider  Unix,  APL,  Pascal, Modula, the
Smalltalk interface, even Fortran;  and  contrast  them  with  Cobol,
PL/I, Algol, MVS/370, and MS-DOS.                  - Fred Brooks, Jr.


More information about the U-Boot mailing list