[U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef

Wolfgang Denk wd at denx.de
Thu Nov 24 07:13:24 CET 2011


Dear Jason Hui,

In message <CAFQ4atSGoTA9YXHxiprdRrWw4E5VFfssOoYOS=N2Yj=q9j_+TQ at mail.gmail.com> you wrote:
>
> Really? As I understand:
> 
> CONFIG_OPTION is for an option selectable by user, so if we:
> #define CONFIG_OPTION
> 
> means we select this feature or something like that.
> 
> CONFIG_SYS_XXXX: means the option is depend on the HW, typically,
> it will have one value at the end. For example:
> 
> #define CONFIG_SYS_XXX     yyy
> 
> Since there is a lot of inconsistency in the u-boot. I don't know what is
> definitely correct way.

Your understanding is not correct, that's all.

There user configurable settings that just select features (like
adding support for optional features, say things like
CONFIG_CMD_ASKENV, CONFIG_CMD_CONSOLE, CONFIG_CMD_IMI etc.), but there
are also such options that take values, like for example
CONFIG_BAUDRATE, CONFIG_BOOTDELAY or CONFIG_BOOTCOMMAND.

The same applies for the CONFIG_SYS_ variables - there are some that
don't take values, and some do.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
While most peoples' opinions change, the conviction of their correct-
ness never does.


More information about the U-Boot mailing list