[U-Boot] [PATCH] cmd_nvedit.c: Fix compiler warning introduced by checkpatch cleanup

Igor Grinberg grinberg at compulab.co.il
Thu Nov 24 08:33:20 CET 2011


Hi Kumar,

Sorry for that one.

On 11/23/11 21:48, Kumar Gala wrote:
> cmd_nvedit.c: In function 'do_env_grep':
> cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value
> 
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>

Acked-by: Igor Grinberg <grinberg at compulab.co.il>

> ---
>  common/cmd_nvedit.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
> index 7409a36..5995354 100644
> --- a/common/cmd_nvedit.c
> +++ b/common/cmd_nvedit.c
> @@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag,
>  
>  	while (arg <= argc) {
>  		idx = 0;
> -		while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) {
> +		while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) {
>  			if (!(matched[idx / 8] & (1 << (idx & 7)))) {
>  				puts(match->key);
>  				puts("=");

-- 
Regards,
Igor.


More information about the U-Boot mailing list