[U-Boot] [PATCH 1/2] ARM: omap3: added common configuration for Technexion TAM3517

[Wolfgang Denk]

Dear Stefano Babic,

In message <4ECE095D.4040700 at denx.de> you wrote:
>
> >> +#undef CONFIG_CMD_FLASH		/* flinfo, erase, protect	*/
> >> +#undef CONFIG_CMD_IMI		/* iminfo			*/
> >> +#undef CONFIG_CMD_IMLS		/* List all found images	*/
> > 
> > Is there any good reason to disable the "iminfo" command?
> 
> Yes - the command relies on NOR flash. In fact, in cmd_bootm.c do_imls()
> needs CONFIG_SYS_MAX_FLASH_BANKS, that has no sense on this SOM, because
> I have not CFI flash.

I was referring to "iminfo", not to "imls".

> NAND_BASE is the address of the controller defined in cpu.h. That iis
> correct.

Arrgh..  I see.

> CONFIG_SYS_NAND_ADDR seems to me obsolete and not used anymore - a lot
> of boards define it, I think it should be globally removed - I start
> dropping from here.

Thanks.  I think after doing this, we should then rename NAND_BASE
into CONFIG_SYS_NAND_ADDR.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are bugs and then there are bugs.  And then there are bugs.
                                                    - Karl Lehenbauer