[U-Boot] [PATCH] drivers/bios_emulator/x86emu/ops2.c: Fix GCC 4.6 build warning

Marek Vasut marek.vasut at gmail.com
Thu Nov 24 23:31:31 CET 2011


Hi,

> Dear Marek Vasut,
> 
> In message <201111241814.34611.marek.vasut at gmail.com> you wrote:
> > > -    char *name = 0;
> > > +    __maybe_unused char *name = 0;
> > 
> > I don't like this __maybe_unused stuff, it seems like you're hiding
> > possible errors.
> 
> I don't like it either, but there are cases where this is the cheapest
> way to get the code clean again, and still working.
> 
> If you have a better proposal to make this file compile clean, without
> using __maybe_unused, then please post your patch.
> 
Honestly, not right now. I'd prefer to work on other stuff that's slightly more 
important (mx51usb, bootz ... pile of other stuff). This patch is of moderate 
importance to me (which means I'll think about it when I'm idle).

Anyway, from now on, I'd like to try picking up gcc4.6 fixes (as I started whole 
this machinery with the debug() macro changes) and start pushing it through -
staging. Are you against it?

M


More information about the U-Boot mailing list