[U-Boot] [PATCH] MX: serial_mxc: cleanup removing nasty #ifdef

Jason Hui jason.hui at linaro.org
Fri Nov 25 03:11:03 CET 2011


On Thu, Nov 24, 2011 at 8:11 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Jason Hui,
>
> In message <CAFQ4atRGwSxiw+mik8wSMMUVW4M=N9WS55PpD1iFhu-E1Aj_Rg at mail.gmail.com> you wrote:
>>
>> I'm just get confused. It seems from you that we can both use:
>> CONFIG_option and CONFIG_SYS_  in this patch? right?
>
> It's one of those boarder cases.  But given that we don't actually set
> hardware related values (say, initial data for registers) here, but
> select from a set of pre-defined options (UART1_BASE etc.) it seems OK
> to me to handle this as Stefano suggested, i. e. as
> CONFIG_MXC_UART_BASE .

OK, thanks Wolfgang.

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
>                                             - Terry Pratchett, _Eric_
>


More information about the U-Boot mailing list