[U-Boot] [PATCH] M28: GPIO pin validity check added

[Wolfgang Denk]

Dear Robert,

In message <EED98926-42E6-49D6-9F55-0FD2F2ED59B7 at delien.nl> you wrote:
> > sorry if my messages have been a bit harsh with gpio freedback.  the unwrapped 
> > lines and broken patch formats make me see red.
> 
> I understand; There are rules to adhere to.
> But please also understand what I'm working with here. Making a single patch takes me - I kid you not - one hour. And still it comes out borked.

Part of this problem might be the result from an attitude of "I don't
have the time to learn doing thisngs right, but I always have time to
repeat them wrongly again and again".

For example, you still haven't figured out how to configure your
mailer so it wraps lines after some 70 characters or so.

...
> At the office we're using Perforce. Not a bad system, but it doesn't deal with patches very well and it's inaccessible from my home office. So I'm using Subversion on my NAS as an intermediate archive to work from, committing my changes to P4 every now 
> and then. You guys are using Git; I'm sure it's superior but I don't have time now to figure that one beyond the basics. Every time I need to make or re-make a patch, I have to clone a clean Git repository, revert my SVN workspace back to the work I'm m
> aking a patch off, merge that into the clean Git repository and create a new patch.

This is something that I really cannot understand.  If I find myself
in such a situation, I would probably start tinking what can be done
to avoid such pain when I do this the second time.  If it's any
significant amount of time I would nover do it a third time, but
rather think of alternatives.

For example, why can't you keep a permanent git tree on your system,
and import your SVN stuff into a branch in that repository.

Yes, this might involve learning git, but each hour invested in that
is _much_ better spent then performing repeated, mechanical work.

> And I still have to mail the patch. No attachments allowed, I understand, but copying and pasting between a Linux VM and Windows host trashes the leading space, so I either have to go through the patch and put it back myself. Or I can use Exchange web-b
> ased mail, that sometimes decides to send HTML mail anyway.

Did you read the available instructions for sending patches, or for
configuring mailers not to mess with your code?

> In my home office I'm using a 12-core MacPro as a workstation. Again Linux is under a VM, because I need a Windows VM too, to have crippled access to the office network. To post patches from my home office, I'm using Mac Mail through my own windows serv
> er, but Mail somehow doesn't offer the feature to wrap lines at column 72. Instead it uses the format designator to indicate flow-format, understood by any modern email program, but not anticipating people on the other side receiving email in Vim, or ap
> plying patches directly from their mailbox.

Again, there are _tons_ of checklists on the web that explain how to
configure your MUA - not to mention that there is wide choice of MUA
for basicly all systems.

> So even though I had finally convinced management that it's in their best interest to get our work back into the mainline, I decided to bail out because it's just too much work. Even though not ideal, I think we're better off maintaining our 100 lines w
> orth of work. And even if all technical difficulties could be fixed - I'll express myself mildly, but I cannot leave this unsaid - the social standards here are not really my thing.

Friction usually requires two sides...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream  things  that  never
were; and I say ``Why not?''
       - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1