[U-Boot] [PATCH] board/esd/cpci405/cpci405.c: Fix GCC 4.6 warning

Mike Frysinger vapier at gentoo.org
Fri Nov 25 20:56:10 CET 2011


On Friday 25 November 2011 03:33:39 Marek Vasut wrote:
> > On Thursday 24 November 2011 10:39:21 Matthias Fuchs wrote:
> > > -	sprintf(str, "%08X%04X",
> > > -		*(unsigned int *)&ow_id[0],
> > > -		*(unsigned short *)&ow_id[4]);
> > > +	sprintf(str, "%02X%02X%02X%02X%02X%02X",
> > > +		ow_id[0], ow_id[1], ow_id[2], ow_id[3], ow_id[4], ow_id[5]);
> > 
> > use __get_unaligned_le32 and __get_unaligned_le16 helpers to avoid having
> > to decode each byte.
> 
> Is there any overhead introduced ?

i imagine get_unaligned will be as worse as indexing every byte (which is what 
Matthias is proposing we change to), or as good as the current code (just 
casting the data).  depends on the arch.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20111125/ff236d18/attachment.pgp>


More information about the U-Boot mailing list