[U-Boot] [PATCH] Blackfin: br4: new board port

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201111251614.47433.vapier at gentoo.org> you wrote:
> i tweaked a few things (like disabling the CONFIG_ETHADDR).  same question for
> this board ... where is the MAC normally stored ?
> 
> updated patch is below
> -mike
> 
> From 6ff79ef55cb414b0dfb08b8aa9db2baf8849545b Mon Sep 17 00:00:00 2001
> From: Dimitar Penev <dpn at switchfin.org>
> Date: Fri, 25 Nov 2011 16:05:54 -0500
> Subject: [PATCH] Blackfin: br4: new board port
> 
> This adds support for the BR4 Appliance.  It is a quad channel ISDN BRI
> board based on Blackfin BF537 CPU.
> 
> Signed-off-by: Dimitar Penev <dpn at switchfin.org>
> Signed-off-by: Mike Frysinger <vapier at gentoo.org>

...
> +#ifndef __ADSPBF534__
> +#define ADI_CMDS_NETWORK	1
> +#define CONFIG_BFIN_MAC
> +#define CONFIG_NETCONSOLE	1

These #defines should have no values.

> +#endif
> +#define CONFIG_HOSTNAME		br4
> +#define CONFIG_IPADDR		192.168.1.100
> +#define CONFIG_GATEWAYIP	192.168.1.1
> +#define CONFIG_SERVERIP		192.168.1.2
> +#define CONFIG_TFTP_BLOCKSIZE	4404

NAK.

> +/* Uncomment next line to use fixed MAC address */
> +/* #define CONFIG_ETHADDR	5c:38:1a:80:a7:00 */

Please don't add dead code.

> +#define CONFIG_BFIN_TWI_I2C	1
> +#define CONFIG_HARD_I2C		1

These #defines should have no values.

Please fix globally.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Can you imagine how life could be improved if we could do away with
jealousy, greed, hate ..."
"It can also be improved by eliminating love, tenderness, sentiment
-- the other side of the coin"
	-- Dr. Roger Corby and Kirk, "What are Little Girls Made Of?",
	   stardate 2712.4