[U-Boot] [PATCH] Blackfin: br4: new board port

Dimitar Penev dpn at switchfin.org
Mon Nov 28 12:45:12 CET 2011


Dear Wolfgang Denk,

> Dear Mike Frysinger,

>
>> > > +#define CONFIG_HOSTNAME br4
>> > > +#define CONFIG_IPADDR 192.168.1.100
>> > > +#define CONFIG_GATEWAYIP 192.168.1.1
>> > > +#define CONFIG_SERVERIP 192.168.1.2
>> > > +#define CONFIG_TFTP_BLOCKSIZE 4404
>> >
>> > NAK.
>>
>> i'm guessing you're only NAK-ing the middle three lines
>
> Right.
>
> I have to admit that I'm not sure i having the last ine is a clever
> idea, but in any case it's not my problem.

I have not dug in the code to understand the impact in details but what I 
have observed is that the
tftp transfer in our local network is getting speeded up few times with the 
last line added.
It is for the files in the 10 MB size range in case it matters.

Probably you can just mention the expected negative side of this line?

Thank you
Dimitar Penev

>
> Best regards,
>
> Wolfgang Denk
>
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> He'd heard her use that sweet, innocent  tone  of  voice  before.  It
> meant that, pretty soon, there was going to be trouble.
>                                        - Terry Pratchett, _Truckers_
> 



More information about the U-Boot mailing list