[U-Boot] [PATCH 1/6] tegra: Move cpu_init_cp15() to arch_cpu_init()
Simon Glass
sjg at chromium.org
Mon Nov 28 20:00:01 CET 2011
Hi Mike,
On Wed, Nov 23, 2011 at 3:34 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Wednesday 23 November 2011 17:59:03 Simon Glass wrote:
>> --- a/arch/arm/cpu/armv7/tegra2/board.c
>> +++ b/arch/arm/cpu/armv7/tegra2/board.c
>> @@ -80,6 +80,9 @@ int arch_cpu_init(void)
>> {
>> /* Fire up the Cortex A9 */
>> tegra2_start();
>> +
>> + /* We didn't do this init in start.S, so do it now */
>> + cpu_init_cp15();
>> return 0;
>> }
>
> probably a pain since you've got a bunch of little patches, but there should
> be a blank line before that return statement. it was semi-OK because before
> there were only two statements in this func, but now that there are more, the
> return should be by itself.
No pain, thanks for picking this up.
>
> i'll leave it up to you/tegra-maintainer if this really needs to get fixed in
> all the patches, or just the last one.
> -mike
>
Regards,
Simon
More information about the U-Boot
mailing list