[U-Boot] [PATCH v3] ftsdc010: improve performance and capability

[Macpaul Lin]

Hi Andy

2011/11/29 Andy Fleming <afleming at gmail.com>

>  >> >
> >> >                        clear |= FTSDC010_STATUS_DATA_TIMEOUT;
> >>
> >> Why set clear? This code returns before clear is written.
> >> >                        writel(sta, &host->reg->clr);
> >> > +
> >> >                        return TIMEOUT;
> >
> > Why did you say the code "returns before clear is written"?
>
> I'm saying this sets "clear" to FTSDC010_STATUS_DATA_TIMEOUT, but then
> it writes "sta" to the clr register, and returns.
>
> "clear" is never used after being set in this case.


You're really caught a bug. Sorry I didn't aware what you meant before.
I thought I've fix this bug at the 1st version of the patch. This is weird.
Anyway, I'll fix this in patch v4 also.
Thanks!

-- 
Best regards,
Macpaul Lin