[U-Boot] [PATCH v6] net: ll_temac: Add LL TEMAC driver to u-boot

[Stephan Linz]

Am Sonntag, den 27.11.2011, 23:29 +0100 schrieb Wolfgang Denk: 
> Dear Stephan Linz,
> 
--snip-- 
> 
> > This special 'DCR' function can map into indirect DCR access. But
> > unfortunately in_be32() and out_be32() for Microblaze are not real
> > functions. They are CPP defines :-(
> 
> Change it?  Turning them into inline functions should be not too
> difficult.

Hello Wolfgang,
Hello Michal,

I have sync arch/microblaze/include/asm/io.h with Linux kernel code. Now
I ask me whether there is any option to test all the io helper functions
in a simple way? Do you know one?

Best regards,
Stephan

> 
> > I will review arch/microblaze/include/asm/io.h together with Michal.
> > Until then it would be nice if we could keep this code as it is. I will
> > fix the dublicate code if we have in/out functions -- no defines.
> 
> Hm... past experience has shown that the stragey of adding bad code
> first and then cleaning it up has never worked really well, nor fast. 
> Insisting on clean patches from the beginning is probably more
> painful, but almost always faster, and more reliable.
> 
> Best regards,
> 
> Wolfgang Denk
> 

-- 
Viele Grüße,
Stephan Linz
______________________________________________________________________________
MB-Ref: http://www.li-pro.de/xilinx_mb:mbref:start
OpenDCC: http://www.li-pro.net/opendcc.phtml
PC/M: http://www.li-pro.net/pcm.phtml
Sourceforge: http://sourceforge.net/users/slz
Gitorious: https://gitorious.org/~slz