[U-Boot] [PATCH v4 7/7] arm, davinci: Remove duplication of pinmux configuration code

[Tom Rini]

On Tue, Nov 29, 2011 at 2:24 PM, Tom Rini <tom.rini at gmail.com> wrote:
> On Tue, Nov 29, 2011 at 2:46 AM, Christian Riesch
> <christian.riesch at omicron.at> wrote:
>> This patch replaces the pinmux configuration code in
>> arch/arm/cpu/arm926ejs/davinci/da850_lowlevel.c by the code from
>> arch/arm/cpu/arm926ejs/davinci/pinmux.c.
> [snip]
>> +/* pinmux_resource[] vector is defined in the board specific file */
>> +extern const struct pinmux_resource pinmuxes[];
>> +extern const int pinmuxes_size;
>
> This is a checkpatch warning.  I've moved the extern / comment to
> <asm/arch/da850_lowlevel.h>.

And on further review / hair pulling, unchanged.  The code makes more
sense with the externs not hidden and is better with this change than
without but I think we need to find something a bit more clever still
than what's going on today or was going on before (with pinmux being
done in board_init).  In this case I also don't think adding
spl_board_init() will help matters.

-- 
Tom