[U-Boot] [PATCH 0/4] Add support for the 32 bit boot protocol to the x86 zboot command.

Graeme Russ graeme.russ at gmail.com
Wed Nov 30 23:04:46 CET 2011


Hi Gabe,

On Wed, Nov 30, 2011 at 8:28 PM, Graeme Russ <graeme.russ at gmail.com> wrote:
> Hi Gabe,
>
> On 30/11/11 20:17, Gabe Black wrote:
>> These four patches add support for the 32 bit Linux boot protocol to the
>> zboot command. They also add support for an initrd.
>>
>>
>> Gabe Black (4):
>>   x86: Clean up the x86 zimage code in preparation to extend it
>>   x86: Add support for booting Linux using the 32 bit boot protocol
>>   x86: Refactor the zboot innards so they can be reused with a vboot
>>     image
>>   x86: Add support for specifying an initrd with the zboot command
>>
>>  arch/x86/include/asm/zimage.h |   31 +----
>>  arch/x86/lib/bootm.c          |   21 +++-
>>  arch/x86/lib/zimage.c         |  257 ++++++++++++++++++++++++++---------------
>>  3 files changed, 183 insertions(+), 126 deletions(-)
>
> The only real concern I have right now is that this series, which is purely
> x86, relies on functionality introduced in the "Add code to read in the
> coreboot tables and     fill in memory info" series. Specifically,
> install_e820_map() is in only in arch/x86/cpu/coreboot/sdram.c

Ignore me ;) - I realise now that there is a weak stub function

Can you please move the changes to arch/x86/include/asm/zimage.h and
arch/x86/lib/zimage.c from the "x86: Add infrastructure to extract an e820
table from the coreboot tables" patch into this series - That, I think,
will make them stand-alone and make the other series coreboot only

Regards,

Graeme


More information about the U-Boot mailing list