[U-Boot] [PATCH 3/8] PPC: Fix i82365.c by removing ifdef around "buf"

Marek Vasut marek.vasut at gmail.com
Mon Oct 3 02:57:25 CEST 2011


From: Marek Vasut <marex at pollux.denx.de>

As the "buf" is cleared at runtime, this might introduce a slight overhead.

Signed-off-by: Marek Vasut <marex at pollux.denx.de>
---
 drivers/pcmcia/i82365.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


Q: Can this be squashed into char buf[200] = {0}; ? That'd help the
   optimization to remove the overhead altogether again.


diff --git a/drivers/pcmcia/i82365.c b/drivers/pcmcia/i82365.c
index 1bcb3a5..968d35a 100644
--- a/drivers/pcmcia/i82365.c
+++ b/drivers/pcmcia/i82365.c
@@ -272,11 +272,9 @@ static u_int cirrus_set_opts (socket_info_t * s)
 {
 	cirrus_state_t *p = &s->c_state;
 	u_int mask = 0xffff;
-#if DEBUG
 	char buf[200];
 
 	memset (buf, 0, 200);
-#endif
 
 	if (has_ring == -1)
 		has_ring = 1;
-- 
1.7.6.2



More information about the U-Boot mailing list