[U-Boot] [PATCH v3 06/21] sandbox: Add architecture lib files

Mike Frysinger vapier at gentoo.org
Mon Oct 3 08:15:15 CEST 2011


On Monday, September 26, 2011 20:10:40 Simon Glass wrote:
> +	gd->mon_len = 0; /* _bss_end_ofs;*/

i'd scrub references to this and drop it from the global header

> +	size = 128 * 1024 * 1024;
> +	mem = malloc(size);
> +	assert(mem);
> +	gd->ram_buf = mem;

shouldn't this 128 MiB be a config ?

> +#ifdef CONFIG_POST
> +	post_bootmode_init();
> +	post_run(NULL, POST_ROM | post_bootmode_get(0));
> +#endif

i wonder if you shouldn't just drop all the POST stuff for now ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111003/275e299a/attachment.pgp 


More information about the U-Boot mailing list