[U-Boot] [PATCH 5/8] PPC: Fix pd67290.c by removing ifdef around "buf"

Wolfgang Denk wd at denx.de
Mon Oct 3 16:32:05 CEST 2011


Dear Marek Vasut,

In message <1317603450-7527-6-git-send-email-marek.vasut at gmail.com> you wrote:
> From: Marek Vasut <marex at pollux.denx.de>

Fix...

> As the "buf" is cleared at runtime, this might introduce a slight overhead.
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  board/cpc45/pd67290.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/board/cpc45/pd67290.c b/board/cpc45/pd67290.c
> index 0d8ef23..96d7289 100644
> --- a/board/cpc45/pd67290.c
> +++ b/board/cpc45/pd67290.c
> @@ -225,11 +225,9 @@ static u_int cirrus_set_opts (socket_info_t * s)
>  {
>  	cirrus_state_t *p = &s->c_state;
>  	u_int mask = 0xffff;
> -#if DEBUG
>  	char buf[200];
>  
>  	memset (buf, 0, 200);
> -#endif

NAK due to code size increase.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"A verbal contract isn't worth the paper it's printed on."
- Samuel Goldwyn


More information about the U-Boot mailing list