[U-Boot] [PATCH] cmd_sf: Fix compiler warning

Kumar Gala galak at kernel.crashing.org
Mon Oct 3 16:35:47 CEST 2011


cmd_sf.c: In function 'do_spi_flash':
cmd_sf.c:164:9: warning: 'skipped' may be used uninitialized in this function

Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
---
 common/cmd_sf.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/common/cmd_sf.c b/common/cmd_sf.c
index c8c547a..7225656 100644
--- a/common/cmd_sf.c
+++ b/common/cmd_sf.c
@@ -161,12 +161,11 @@ static int spi_flash_update(struct spi_flash *flash, u32 offset,
 	char *cmp_buf;
 	const char *end = buf + len;
 	size_t todo;		/* number of bytes to do in this pass */
-	size_t skipped;		/* statistics */
+	size_t skipped = 0;	/* statistics */
 
 	cmp_buf = malloc(flash->sector_size);
 	if (cmp_buf) {
-		for (skipped = 0; buf < end && !err_oper;
-				buf += todo, offset += todo) {
+		for (; buf < end && !err_oper; buf += todo, offset += todo) {
 			todo = min(end - buf, flash->sector_size);
 			err_oper = spi_flash_update_block(flash, offset, todo,
 					buf, cmp_buf, &skipped);
@@ -181,6 +180,7 @@ static int spi_flash_update(struct spi_flash *flash, u32 offset,
 	}
 	printf("%zu bytes written, %zu bytes skipped\n", len - skipped,
 	       skipped);
+
 	return 0;
 }
 
-- 
1.7.3.4



More information about the U-Boot mailing list