[U-Boot] [PATCH 2/2] Tegra2: Add support for Toradex Colibri T20 board

[Stephen Warren]

Marek Vasut wrote at Monday, October 03, 2011 4:36 AM:
...
> > > +static void pinmux_init(void)
> > > +{
> > > +       struct pmux_tri_ctlr *pmt = (struct pmux_tri_ctlr *)NV_PA_APB_MISC_BASE; +
> > > +       /* SDIO 1 */
> > > +       clrbits_le32(&pmt->pmt_tri[TRISTATE_REG(PIN_ATA)], 1 << 30);
> > > +
> > > +       /* Mux SDB/SDC to PWM */
> > > +       clrsetbits_le32(&pmt->pmt_ctl_d, 0xcc00, 0x4400);
> > > +
> > > +       /* Mux SDIO1 to UARTA */
> > > +       setbits_le32(&pmt->pmt_ctl_a, 3 << 30);
> > > +
> > > +       return 0;
> > > +}
> >
> > There are pinmux functions also :-)
> 
> Really ? Where are these ?!

Simon sent them to the list, but I don't think they've been checked in
yet; see:

http://patchwork.ozlabs.org/project/uboot/list/?submitter=6170&state=1&q=tegra2

> > > b/include/configs/colibri_t20.h new file mode 100644
...
> > > +#include <asm/sizes.h>
> > > +#include <asm/arch/tegra2.h>
> >
> > Are you ok with including tegra2-common.h here?
> 
> No, I had to do multiple changes (like different stack position etc).

Can't tegra2-common.h be parameterized or overridden? It'd be nice not
to have to duplicate its content, and to have one place that affects
all Tegra systems.

-- 
nvpublic