[U-Boot] [PATCH v3 16/21] sandbox: Add serial uart

[Simon Glass]

Hi Mike,

On Mon, Oct 3, 2011 at 12:42 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday, September 26, 2011 20:10:50 Simon Glass wrote:
>> +int serial_init(void)
>> +{
>> +     return 0;
>> +}
>
> this probably should set the tty to raw input with termios.  if you're not
> familiar with the termios API, just lemme know, and i can send you a chunk of
> code to do what you need.

Yes I know what you mean.

How would this cope with having a script controlling it? We would need
to check for a terminal and do something different in that case,
right?

Can we leave this until later?

>
>> +void serial_exit(void)
>> +{
>> +}
>
> no one actually implements this :).  just delete it, and i'll delete the
> prototype from common.h.

OK

>
>> +int serial_tstc(void)
>> +{
>> +     return 0;
>> +}
>
> once serial_init() reconfigures the tty to a more "serial" like mode, you can
> implement this properly.
> -mike
>

Well yes, but I would prefer to leave this for now.

Regards,
Simon