[U-Boot] [PATCH] powerpc/mpc8xxx: Fix ddr build error

Tabi Timur-B04825 B04825 at freescale.com
Tue Oct 4 03:40:46 CEST 2011


On Mon, Oct 3, 2011 at 6:59 PM, Becky Bruce <beckyb at kernel.crashing.org> wrote:

> -#ifdef DEBUG
>  const char *step_string_tbl[] = {
>        "STEP_GET_SPD",
>        "STEP_COMPUTE_DIMM_PARMS",
> @@ -153,7 +152,6 @@ const char * step_to_string(unsigned int step) {
>
>        return step_string_tbl[s];
>  }
> -#endif

How big is this array?  It looks like it's going to add a bunch of
data to the u-boot image that will typically never be used, since
DEBUG is usually not defined.

There should be an easy way to keep this array defined only when DEBUG
is defined.

> --
> 1.5.6.5

Your version of git is outdated, BTW.

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the U-Boot mailing list