[U-Boot] [PATCH] BeagleBoard: match gpio_request() and gpio_free()

[Mike Frysinger]

On Tuesday, October 04, 2011 03:59:19 In-Bae Jeong wrote:
> -	if (!gpio_request(171, "") &&
> -	    !gpio_request(172, "") &&
> -	    !gpio_request(173, "")) {
> +	if (gpio_request(171, "")) {
> +		error = 171;
> +		goto GPIO_171_ERR;
> +	}
> +	if (gpio_request(172, "")) {
> +		error = 172;
> +		goto GPIO_172_ERR;
> +	}
> +	if (gpio_request(173, "")) {
> +		error = 173;
> +		goto GPIO_173_ERR;
> +	}

why isn't this code passing a proper label to gpio_request() ?

> +GPIO_NO_ERR:  gpio_free(173);
> +GPIO_173_ERR: gpio_free(172);
> +GPIO_172_ERR: gpio_free(171);
> +GPIO_171_ERR:

labels and statements should not be on the same line

also, lose the caps
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111004/63e17ef0/attachment.pgp