[U-Boot] [PATCH] powerpc/85xx: fix null pointer dereference when initializing the SGMII TBI PHY

[Kumar Gala]

On Oct 4, 2011, at 4:44 PM, Timur Tabi wrote:

> Function dtsec_configure_serdes() needs to know where the TBI PHY registers
> are in order to configure SGMII for proper SerDes operation.
> 
> During SGMII initialzation, fm_eth_init_mac() passing NULL for 'phyregs' when
> it called init_dtsec(), because it was believed that phyregs was not used.
> In fact, it is used by dtsec_configure_serdes() to configure the TBI PHY
> registers.
> 
> We also need to define the PHY registers in struct fm_mdio.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
> 
> Note: I'm not sure of my change to struct fm_mdio.  It works, but it doesn't
> smell right.

What exactly is the concern?

- k