[U-Boot] [PATCH v2 05/10] spl, nand: add 4bit HW ecc oob first nand_read_page function

[Heiko Schocher]

Hello Scott,

Scott Wood wrote:
> On 10/05/2011 09:28 AM, Heiko Schocher wrote:
>> similiar to commit dc7cd8e59ba077f3b4c1a4557c9cd86a31b9ab1f, only
>> adapted for the new spl framework.
>>
>> Signed-off-by: Heiko Schocher <hs at denx.de>
>> Cc: Scott Wood <scottwood at freescale.com>
>> Cc: Albert ARIBAUD <albert.u.boot at aribaud.net>
>> Cc: Sandeep Paulraj <s-paulraj at ti.com>
>> ---
>>  drivers/mtd/nand/nand_spl_simple.c |   43 ++++++++++++++++++++++++++++++++++++
>>  1 files changed, 43 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/nand_spl_simple.c b/drivers/mtd/nand/nand_spl_simple.c
>> index 71491d4..7ab332f 100644
>> --- a/drivers/mtd/nand/nand_spl_simple.c
>> +++ b/drivers/mtd/nand/nand_spl_simple.c
[...]
>> @@ -186,6 +227,7 @@ static int nand_read_page(int block, int page, void *dst)
>>  
>>  	return 0;
>>  }
>> +#endif
>>  
>>  int nand_spl_load_image(uint32_t offs, unsigned int size, void *dst)
>>  {
> 
> ACK this part

great!

>> @@ -231,6 +273,7 @@ void nand_init(void)
>>  	nand_chip.IO_ADDR_R = nand_chip.IO_ADDR_W =
>>  		(void  __iomem *)CONFIG_SYS_NAND_BASE;
>>  	nand_chip.options = 0;
>> +	nand_chip.dev_ready = NULL;
>>  	board_nand_init(&nand_chip);
>>  
>>  	if (nand_chip.select_chip)
> 
> This looks unrelated, and if it makes a difference suggests that the BSS
> isn't being cleared.

BSS is cleared at this point, so you are right, above two lines are
not necessary, remove them.

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany