[U-Boot] [PATCH v2 1/3] misc:pmic:core New generic PMIC driver

[Lukasz Majewski]

Hi Stefano,

I suppose you are talking about cases like the following:

> #define CONFIG_SPI_FLASH_CS		(1 | 121 << 8)

Yes, this construct will cause range overflow.

> +struct p_spi {
> +	unsigned char cs;
> +	unsigned char mode;
> +	unsigned char bitlen;

Therefore the above variables need to be at least unsigned shorts.
As you proposed they shall be unsigned int.

On technical question:
Shall I prepare the whole v3 patch series or only v3 for this single
patch ([PATCH v2 1/3] misc:pmic:core New generic PMIC drive)?

What would be easier for You or Wolfgang to pick?


-- 
Best regards,

Lukasz Majewski

Samsung Poland R&D Center
Platform Group