[U-Boot] [PATCH v7 2/3] MIPS: Jz4740: Add NAND driver

Wolfgang Denk wd at denx.de
Thu Oct 6 23:12:05 CEST 2011


Dear Shinya Kuribayashi,

In message <4E886D71.3040704 at pobox.com> you wrote:
> From: Xiangfu Liu <xiangfu at openmobilefree.net>
> Date: Fri, 19 Aug 2011 14:35:29 +0800
> 
> Jz4740 NAND flash controller can support:
> * MLC NAND as well as SLC NAND
> * all 8-bit/16-bit NAND flash devices
> * HAMMING and RS hardware ECC
> * automatic boot up from NAND flash devices
> 
> nand_ecclayout is set up for 2GiB NAND chip mounted in Qi LB60.
> We'll bring up boot-from-NAND support in nand_spl/ in the future.
> 
> Signed-off-by: Xiangfu Liu <xiangfu at openmobilefree.net>
> Acked-by: Daniel <zpxu at ingenic.cn>
> Signed-off-by: Shinya Kuribayashi <skuribay at pobox.com>
> ---
> 
> Changes since v6:
> 
> * Remove NAND-boot stuff.  Those bits will be submitted as a nand-spl
>   support once this Jz4740 base support is merged.
> 
> * All previous comments from Scott are fixed.
> 
> * Bunch of coding style issues fixed.
> 
>  drivers/mtd/nand/Makefile      |    1 +
>  drivers/mtd/nand/jz4740_nand.c |  261 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 262 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mtd/nand/jz4740_nand.c

Checkpatch says:

total: 4 errors, 0 warnings, 268 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If I had to live my life again,  I'd  make  the  same  mistakes, only
sooner.                                          -- Tallulah Bankhead


More information about the U-Boot mailing list