[U-Boot] [PATCH v8 4/4] Add USB support for Efika

Wolfgang Denk wd at denx.de
Thu Oct 6 23:18:01 CEST 2011


Dear Jana Rapava,

In message <1317222457-18412-1-git-send-email-fermata7 at gmail.com> you wrote:
> This commit adds USB support for EfikaMX and EfikaSB.
> 
> Signed-off-by: Jana Rapava <fermata7 at gmail.com>
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> Cc: Remy Bohmer <linux at bohmer.net>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
> Changes for v2:
>   - changed to proper patch
> Changes for v3:
>   - merged other USB patches from u-boot-pxa/efikasb
>   - offset-based access changed to struct-based access
>   - use {clrset,clr,set}bits_le32() calls
>   - CodingStyle and naming cleanup
> Changes for v4:
>    - split into patchset
>    - CodingStyle and naming cleanup
>    - remove endless loops
>    - silence compiler warnings
> Changes for v5:
>      - change order of arguments in ulpi* functions
>      - change type of reg argument
>      - rename offset macro
> Changes for v6:
>       - rebase on top of u-boot-imx/next
>       - cleanup of CodingStyle and comments
>       - use macro machine_is_efikasb()
>       - introduce header file efika.h
> Changes for v7:
>        - add proper header to efika.h
>        - include efika.h into efikamx.c
>        - check return values from ulpi_wait()
> Changes for v8:
> 	- change the return value of ulpi_wait()
> 	- CodingStyle cleanup
> 	- add proper header to efikamx-usb.c
> 
>  board/efikamx/Makefile      |    3 +
>  board/efikamx/efika.h       |   30 +++
>  board/efikamx/efikamx-usb.c |  420 +++++++++++++++++++++++++++++++++++++++++++
>  board/efikamx/efikamx.c     |    3 +
>  include/configs/efikamx.h   |   16 ++
>  5 files changed, 472 insertions(+), 0 deletions(-)
>  create mode 100644 board/efikamx/efika.h
>  create mode 100644 board/efikamx/efikamx-usb.c

Checkpatch says:

total: 1 errors, 0 warnings, 502 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every little picofarad has a nanohenry all its own.      - Don Vonada


More information about the U-Boot mailing list