[U-Boot] [PATCH v2] powerpc/p3060qds: Add board related support for P3060QDS platform

[Wolfgang Denk]

Dear Kumar Gala,

In message <1316799810-30027-1-git-send-email-galak at kernel.crashing.org> you wrote:
> From: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> 
> The P3060QDS is a Freescale reference board for the six-core P3060 SOC.
> 
> P3060QDS Board Overview:
>  Memory subsystem:
>   - 2G Bytes unbuffered DDR3 SDRAM SO-DIMM(64bit bus)
>   - 128M Bytes NOR flash single-chip memory
>   - 16M Bytes SPI flash
>   - 8K Bytes AT24C64 I2C EEPROM for RCW
>  Ethernet:
>   - Eight Ethernet controllers (4x1G + 4x1G/2.5G)
>   - Three VSC8641 PHYs on board (2xRGMII + 1xMII)
>   - Suport multiple Vitesse VSC8234 SGMII Cards in Slot1/2/3
>  PCIe: Two PCI Express 2.0 controllers/ports
>  USB:  Two USB2.0, USB1(TYPE-A) and USB2(TYPE-AB) on board
>  I2C:  Four I2C controllers
>  UART: Supports two dUARTs up to 115200 bps for console
>  RapidIO:  Two RapidIO, sRIO1 and sRIO2
> 
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu at freescale.com>
> Signed-off-by: York Sun <yorksun at freescale.com>
> Signed-off-by: Kumar Gala <galak at kernel.crashing.org>
> ---
> v2:
> * Updated DDR board param table to reduce multiple entries for same
>   settings.  Also restructured tables to reduce size.
> 
>  board/freescale/common/Makefile      |    3 +
>  board/freescale/common/ics307_clk.c  |   21 +-
>  board/freescale/common/qixis.c       |  151 ++++++++++++
>  board/freescale/common/qixis.h       |  101 ++++++++
>  board/freescale/p3060qds/Makefile    |   54 ++++
>  board/freescale/p3060qds/ddr.c       |  218 +++++++++++++++++
>  board/freescale/p3060qds/eth.c       |  440 ++++++++++++++++++++++++++++++++++
>  board/freescale/p3060qds/fixed_ddr.c |  214 +++++++++++++++++
>  board/freescale/p3060qds/p3060qds.c  |  239 ++++++++++++++++++
>  board/freescale/p3060qds/p3060qds.h  |   30 +++
>  boards.cfg                           |    2 +
>  doc/README.p3060qds                  |  111 +++++++++
>  include/configs/P3060QDS.h           |   39 +++
>  include/configs/corenet_ds.h         |    4 +
>  14 files changed, 1619 insertions(+), 8 deletions(-)
>  create mode 100644 board/freescale/common/qixis.c
>  create mode 100644 board/freescale/common/qixis.h
>  create mode 100644 board/freescale/p3060qds/Makefile
>  create mode 100644 board/freescale/p3060qds/ddr.c
>  create mode 100644 board/freescale/p3060qds/eth.c
>  create mode 100644 board/freescale/p3060qds/fixed_ddr.c
>  create mode 100644 board/freescale/p3060qds/p3060qds.c
>  create mode 100644 board/freescale/p3060qds/p3060qds.h
>  create mode 100644 doc/README.p3060qds
>  create mode 100644 include/configs/P3060QDS.h


Checkpatch says:

WARNING: static const char * array should probably be static const
char * const
#1511: FILE: board/freescale/p3060qds/p3060qds.c:84:
+               static const char *freq[] = {"100", "125", "Reserved",


Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
As in certain cults it is possible to kill a process if you know  its
true name.                      -- Ken Thompson and Dennis M. Ritchie