[U-Boot] [PATCH v14 4/9] nds32/ag101: cpu and init funcs of SoC ag101

[Wolfgang Denk]

Dear Macpaul Lin,

In message <1316574638-20460-4-git-send-email-macpaul at andestech.com> you wrote:
> SoC ag101 is the first chip using NDS32 N1213 cpu core.
> Add header file of device offset support for SoC ag101.
> Add main function of SoC ag101 based on NDS32 n1213 core.
> Add lowlevel_init.S and other periphal related code.
> 
> This version of lowlevel_init.S also replace hardcode value
> by MARCO defines from the GPL version andesboot for better
> code quality.
> 
> Signed-off-by: Macpaul Lin <macpaul at andestech.com>
> ---
> Changes for v1-v4:
>   - Code clean up.
> Changes for v5-v6:
>   - Split watchdog.S from lowlevel_init.S.
>   - Fix hardware reset by using watchdog reset in do_reset() in cpu.c.
>    - reset_cpu was remove inside do_reset().
>   - lowlevel_init.S
>    - Change hard code value into MARCO definitions.
>    - ftsmc010
>      - Fix FTSMC020_TPR_AT2 from 1 to 3 (0xff3ff)
>    - ftsdmc021
>      - Fix hardcoded address of CR1, CR2, TR1, TR2, BANK0 registers.
>      - Fix the default configuration value of FTSDMC and FTSMC controller.
>    - Remove some ftpmu010 and flash probe code to C functions.
> Changes for v7:
>   - clean up.
> Changes for v8-v9:
>   - No change.
> Changes for v10:
>   - asm-offset.c: file added for ag101 use only.
>   - ag101/Makefile: add gen-asm-offset support to ag101 for lowlevel_init.S.
>   - Makefile: add gen-asm-offset support for NDS32 based core and SoCs.
>   - cpu.c: remove unused cpu_init().
>   - lowlevel_init.S
>    - Introduce SoC specific gen-asm-offset.h to lowlevel_init.S
>    - Replace routings by macros to made code much easier to understand.
>    - Add debug LED support.
>    - Add CONFIG_MEM_REMAP for those boards must do memort remapping.
> Changes for v11:
>   - arch/nds32/cpu/n1213/ag101/Makefile
>    - replace $(AR) $(call cmd_link_o_target,...)
> Changes for v12:
>   - Simplify the commit log about the part of lowlevel_init.S.
> Changes for v13:
>   - arch/nds32/cpu/n1213/ag101/Makefile: remove unused gen-asm-offset.
>   - Makefile: remove unused gen-asm-offset because merged asm-offsets.
> Changes for v14:
>   - lowlevel_init.S: fix include path of <generated/asm-offsets.h>
> 
>  arch/nds32/cpu/n1213/ag101/Makefile        |   58 +++++++
>  arch/nds32/cpu/n1213/ag101/asm-offsets.c   |   43 +++++
>  arch/nds32/cpu/n1213/ag101/cpu.c           |  200 +++++++++++++++++++++++
>  arch/nds32/cpu/n1213/ag101/lowlevel_init.S |  238 ++++++++++++++++++++++++++++
>  arch/nds32/cpu/n1213/ag101/timer.c         |  204 ++++++++++++++++++++++++
>  arch/nds32/cpu/n1213/ag101/watchdog.S      |   48 ++++++
>  arch/nds32/include/asm/arch-ag101/ag101.h  |   68 ++++++++
>  7 files changed, 859 insertions(+), 0 deletions(-)
>  create mode 100644 arch/nds32/cpu/n1213/ag101/Makefile
>  create mode 100644 arch/nds32/cpu/n1213/ag101/asm-offsets.c
>  create mode 100644 arch/nds32/cpu/n1213/ag101/cpu.c
>  create mode 100644 arch/nds32/cpu/n1213/ag101/lowlevel_init.S
>  create mode 100644 arch/nds32/cpu/n1213/ag101/timer.c
>  create mode 100644 arch/nds32/cpu/n1213/ag101/watchdog.S
>  create mode 100644 arch/nds32/include/asm/arch-ag101/ag101.h

Checkpatch says:

total: 0 errors, 15 warnings, 859 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real programmers can write assembly code in any language.   :-)
                      - Larry Wall in  <8571 at jpl-devvax.JPL.NASA.GOV>