[U-Boot] [PATCH 2/2] powerpc/85xx: don't display address map size (32-bit vs. 36-bit) during boot

Wolfgang Denk wd at denx.de
Thu Oct 6 23:40:25 CEST 2011


Dear Timur Tabi,

In message <1315319767-26906-2-git-send-email-timur at freescale.com> you wrote:
> Most 85xx boards can be built as a 32-bit or a 36-bit.  Current code sometimes
> displays which of these is actually built, but it's inconsistent.  This is
> especially problematic since the "default" build for a given 85xx board can
> be either one, so if you don't see a message, you can't always know which
> size is being used.  Not only that, but each board includes code that displays
> the message, so there is duplication.
> 
> So instead of displaying this message at boot time, the address map size
> information is moved into the 'bdinfo' command.  The board-specific code is
> deleted.
> 
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>  board/freescale/corenet_ds/corenet_ds.c     |    4 ----
>  board/freescale/mpc8536ds/mpc8536ds.c       |    7 +------
>  board/freescale/mpc8572ds/mpc8572ds.c       |    6 +-----
>  board/freescale/p1010rdb/p1010rdb.c         |    6 +-----
>  board/freescale/p1022ds/p1022ds.c           |    8 ++------
>  board/freescale/p1_p2_rdb/p1_p2_rdb.c       |    4 +---
>  board/freescale/p1_p2_rdb_pc/p1_p2_rdb_pc.c |    8 +-------
>  board/freescale/p2020ds/p2020ds.c           |    8 ++------
>  board/freescale/p2041rdb/p2041rdb.c         |    4 ----
>  common/cmd_bdinfo.c                         |    8 ++++++++
>  10 files changed, 17 insertions(+), 46 deletions(-)

Checkpatch says:

total: 0 errors, 2 warnings, 123 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"We don't have to protect the environment -- the Second Coming is  at
hand."                                                   - James Watt


More information about the U-Boot mailing list