[U-Boot] [PATCH v3 3/8] POST: add post_log_res field for post results in global data

Wolfgang Denk wd at denx.de
Thu Oct 6 23:44:05 CEST 2011


Dear Valentin Longchamp,

In message <1314975550-15766-4-git-send-email-valentin.longchamp at keymile.com> you wrote:
> The current post_log_word in global data is currently split into 2x
> 16 bits: half for the test start, half for the test success.
> Since we alredy have more than 16 POST tests defined and more could
> be defined, this may result in an overflow and the post_output_backlog
> would not work for the tests defined further of these 16 positions.
> 
> An additional field is added to global data so that we can now support up
> to 32 (depending of architecture) tests. The post_log_word is only used
> to record the start of the test and the new field post_log_res for the
> test success (or failure). The post_output_backlog is for this change
> also adapted.
> 
> Signed-off-by: Valentin Longchamp <valentin.longchamp at keymile.com>
> Signed-off-by: Holger Brunck <holger.brunck at keymile.com>
> Acked-by: Mike Frysinger <vapier at gentoo.org>
> ---
>  arch/arm/include/asm/global_data.h      |    1 +
>  arch/blackfin/include/asm/global_data.h |    1 +
>  arch/nios2/include/asm/global_data.h    |    1 +
>  arch/powerpc/include/asm/global_data.h  |    1 +
>  arch/sparc/include/asm/global_data.h    |    1 +
>  post/post.c                             |    9 +++++----
>  6 files changed, 10 insertions(+), 4 deletions(-)

Checkpatch says:

total: 0 errors, 1 warnings, 67 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When choosing between two evils, I always like to take the  one  I've
never tried before.                     -- Mae West, "Klondike Annie"


More information about the U-Boot mailing list