[U-Boot] [PATCH V2] Global Data: Flagify have_console and env_valid

Wolfgang Denk wd at denx.de
Thu Oct 6 23:48:36 CEST 2011


Dear Graeme Russ,

In message <1314365780-15051-1-git-send-email-graeme.russ at gmail.com> you wrote:
> 
> Signed-off-by: Graeme Russ <graeme.russ at gmail.com>
> ---
> Changes since V1:
>  - In common/console.c, gd->flags &= GD_FLG_HAVE_CONSOLE change to |=
> 
>  arch/arm/include/asm/global_data.h        |    5 ++-
>  arch/avr32/include/asm/global_data.h      |    5 ++-
>  arch/blackfin/include/asm/global_data.h   |    5 ++-
>  arch/blackfin/lib/board.c                 |    2 -
>  arch/m68k/include/asm/global_data.h       |    5 ++-
>  arch/microblaze/include/asm/global_data.h |    5 ++-
>  arch/mips/include/asm/global_data.h       |    5 ++-
>  arch/nios2/include/asm/global_data.h      |    5 ++-
>  arch/powerpc/cpu/mpc5xxx/i2c.c            |   20 ++++++------
>  arch/powerpc/cpu/mpc8xx/i2c.c             |   12 ++++----
>  arch/powerpc/include/asm/global_data.h    |    5 ++-
>  arch/sh/include/asm/global_data.h         |    5 ++-
>  arch/sparc/include/asm/global_data.h      |    5 ++-
>  arch/x86/include/asm/global_data.h        |   36 +++++++++++-----------
>  board/edb93xx/edb93xx.c                   |    2 +-
>  board/matrix_vision/common/mv_common.c    |    2 +-
>  board/zeus/zeus.c                         |    2 +-
>  common/console.c                          |    4 +-
>  common/env_common.c                       |    6 ++--
>  common/env_dataflash.c                    |    6 ++--
>  common/env_eeprom.c                       |   36 +++++++++++-----------
>  common/env_flash.c                        |   26 ++++++++--------
>  common/env_mgdisk.c                       |    2 +-
>  common/env_mmc.c                          |    2 +-
>  common/env_nand.c                         |   45 +++++++++++++++-------------
>  common/env_nowhere.c                      |    2 +-
>  common/env_nvram.c                        |    4 +-
>  common/env_onenand.c                      |    4 +-
>  common/env_sf.c                           |   31 +++++++++++--------
>  drivers/i2c/ppc4xx_i2c.c                  |    2 +-
>  drivers/i2c/soft_i2c.c                    |    6 ++--
>  include/environment.h                     |   18 +++++++++++
>  32 files changed, 177 insertions(+), 143 deletions(-)

Checkpatch says:

total: 3 errors, 43 warnings, 901 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q: How do you spell "onomatopoeia"?
A: The way it sounds.


More information about the U-Boot mailing list