[U-Boot] [PATCH v2] powerpc/mpc83xx: Rename CONFIG_SYS_DDR_CONFIG and cleanup DDR csbnds code

Wolfgang Denk wd at denx.de
Thu Oct 6 23:52:14 CEST 2011


Dear Joe Hershberger,

In message <1313542093-7252-1-git-send-email-joe.hershberger at ni.com> you wrote:
> Rename CONFIG_SYS_DDR_CONFIG to include which CS it is configuring
> Cleanup the setting of the csnbds to respect the setting of CONFIG_SYS_DDR_SDRAM_BASE
> Use __ilog2 instead of writing the code to compute it
> Disable unused CS configs
> Ensure ddrlaw.bar is configured
> 
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> ---
> Changes for v2:
>  - Changed from CONFIG_SYS_DDR_CS_CONFIG to CONFIG_SYS_DDR_CS[x]_CONFIG where [x] is the actual CS used
>  - Cleaup code that uses the csbnds associated with the DDR_CS_CONFIG
> 
>  board/freescale/mpc8313erdb/sdram.c       |    9 +++++-
>  board/freescale/mpc8349emds/mpc8349emds.c |   26 +++++++++----------
>  board/freescale/mpc8349itx/mpc8349itx.c   |   26 ++++++++++---------
>  board/freescale/mpc8360emds/mpc8360emds.c |   39 +++++++++++++++++------------
>  board/sbc8349/sbc8349.c                   |   26 +++++++++----------
>  board/ve8313/ve8313.c                     |    9 +++++-
>  include/configs/MPC8313ERDB.h             |    2 +-
>  include/configs/MPC8349EMDS.h             |    2 +-
>  include/configs/MPC8349ITX.h              |    2 +-
>  include/configs/MPC8360EMDS.h             |    3 +-
>  include/configs/sbc8349.h                 |    2 +-
>  include/configs/ve8313.h                  |    2 +-
>  12 files changed, 82 insertions(+), 66 deletions(-)

Checkpatch says:

total: 8 errors, 19 warnings, 245 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every revolutionary idea - in science, politics, art, or  whatever  -
evokes three stages of reaction in a hearer:
  1. It is completely impossible - don't waste my time.
  2. It is possible, but it is not worth doing.
  3. I said it was a good idea all along.


More information about the U-Boot mailing list