[U-Boot] [PATCH v6 3/4] mpc83xx: Add a GPIO driver for the MPC83XX family

Wolfgang Denk wd at denx.de
Thu Oct 6 23:55:56 CEST 2011


Dear Joe Hershberger,

In message <1313194256-23007-3-git-send-email-joe.hershberger at ni.com> you wrote:
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Kim Phillips <kim.phillips at freescale.com>
> ---
> Changes for v2:
>  - Improved names of INIT constants (to include "CONFIG_")
>  - Moved changes to board/freescale/mpc8313erdb/mpc8313erdb.c to patch 2/2
> Changes for v3:
>  - gpio_init_* is now mpc83xx_gpio_init_*
> Changes for v4:
>  - no volatile
>  - no camelCase
>  - use i/o accessors
> Changes for v5:
> Changes for v6:
>  - update to use new GPIO API
> 
>  arch/powerpc/include/asm/arch-mpc83xx/gpio.h |   37 +++++
>  drivers/gpio/Makefile                        |    1 +
>  drivers/gpio/mpc83xx_gpio.c                  |  194 ++++++++++++++++++++++++++
>  3 files changed, 232 insertions(+), 0 deletions(-)
>  create mode 100644 arch/powerpc/include/asm/arch-mpc83xx/gpio.h
>  create mode 100644 drivers/gpio/mpc83xx_gpio.c

Checkpatch says:

total: 0 errors, 2 warnings, 238 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How many DEC repairman does it take to fix a flat?
A:  Five; four to hold the car up and one to swap tires.
Q:  How long does it take?
A:  It's indeterminate.  It will depend upon how many flats they've
    brought with them.
Q:  What happens if you've got TWO flats?
A:  They replace your generator.


More information about the U-Boot mailing list