[U-Boot] [PATCH 1/1 V2] add support for mcf5307 cpu

Wolfgang Denk wd at denx.de
Fri Oct 7 00:00:04 CEST 2011


Dear Angelo Dureghello,

In message <4E444780.9040807 at gmail.com> you wrote:
> Add cpu related files and memory map includes. Apply the related
> minor changes to general coldfire architecture include files.
> 
> Signed-off-by: Angelo Dureghello <sysamfw at gmail.com>
> ---
>  arch/m68k/cpu/mcf530x/Makefile     |   48 +++++++
>  arch/m68k/cpu/mcf530x/config.mk    |   25 ++++
>  arch/m68k/cpu/mcf530x/cpu.c        |   48 +++++++
>  arch/m68k/cpu/mcf530x/cpu.h        |   33 +++++
>  arch/m68k/cpu/mcf530x/cpu_init.c   |  164 +++++++++++++++++++++++
>  arch/m68k/cpu/mcf530x/interrupts.c |   42 ++++++
>  arch/m68k/cpu/mcf530x/speed.c      |   36 +++++
>  arch/m68k/cpu/mcf530x/start.S      |  253 ++++++++++++++++++++++++++++++++++++
>  arch/m68k/include/asm/immap_5307.h |   78 +++++++++++
>  arch/m68k/include/asm/m5307.h      |  119 +++++++++++++++++
>  10 files changed, 846 insertions(+), 0 deletions(-)
>  create mode 100644 arch/m68k/cpu/mcf530x/Makefile
>  create mode 100644 arch/m68k/cpu/mcf530x/config.mk
>  create mode 100644 arch/m68k/cpu/mcf530x/cpu.c
>  create mode 100644 arch/m68k/cpu/mcf530x/cpu.h
>  create mode 100644 arch/m68k/cpu/mcf530x/cpu_init.c
>  create mode 100644 arch/m68k/cpu/mcf530x/interrupts.c
>  create mode 100644 arch/m68k/cpu/mcf530x/speed.c
>  create mode 100644 arch/m68k/cpu/mcf530x/start.S
>  create mode 100644 arch/m68k/include/asm/immap_5307.h
>  create mode 100644 arch/m68k/include/asm/m5307.h

CamelCase identifiers are not allowed.

Also, checkpatch says:

total: 34 errors, 31 warnings, 846 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Too much of anything, even love, isn't necessarily a good thing.
	-- Kirk, "The Trouble with Tribbles", stardate 4525.6


More information about the U-Boot mailing list