[U-Boot] [PATCH v2 1/5] usb:gadget:s5p USB Device Controller (UDC) implementation

Wolfgang Denk wd at denx.de
Fri Oct 7 00:10:48 CEST 2011


Dear Lukasz Majewski,

In message <1310567392-29082-2-git-send-email-l.majewski at samsung.com> you wrote:
> This commit provides UDC driver support for Samsung's SoC
> family of processors.
> 
> Signed-off-by: Lukasz Majewski <l.majewski at samsung.com>
> Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park at samsung.com>
> Cc: Minkyu Kang <mk7.kang at samsung.com>
> Cc: Remy Bohmer <linux at bohmer.net>
> 
> ---
> Changes for v2:
> 	- Coding cleanups and fixes
> 	- s3c_udc* files history and origination added
> 	- regs-otg.h rewritten to use structs instedad of
> 	  #defines
> ---
>  drivers/usb/gadget/Makefile               |    6 +-
>  drivers/usb/gadget/regs-otg.h             |  209 +++++
>  drivers/usb/gadget/s3c_udc_otg.c          |  892 ++++++++++++++++++
>  drivers/usb/gadget/s3c_udc_otg_xfer_dma.c | 1419 +++++++++++++++++++++++++++++
>  include/usb/lin_gadget_compat.h           |   66 ++
>  include/usb/s3c_udc.h                     |  160 ++++
>  6 files changed, 2749 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/usb/gadget/regs-otg.h
>  create mode 100644 drivers/usb/gadget/s3c_udc_otg.c
>  create mode 100644 drivers/usb/gadget/s3c_udc_otg_xfer_dma.c
>  create mode 100644 include/usb/lin_gadget_compat.h
>  create mode 100644 include/usb/s3c_udc.h

Checkpatch says:

total: 0 errors, 16 warnings, 2758 lines checked

Please clean up and resubmit.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ninety-Ninety Rule of Project Schedules:
        The first ninety percent of the task takes ninety percent of
the time, and the last ten percent takes the other ninety percent.


More information about the U-Boot mailing list