[U-Boot] [PATCH 5/8] ARM: moved general function to arm/lib

[Wolfgang Denk]

Dear stefano babic,

In message <4E8E279B.8000405 at denx.de> you wrote:
>
> >>  arch/arm/cpu/armv7/Makefile |    2 -
> >>  arch/arm/cpu/armv7/syslib.c |   69 -------------------------------------------
> >>  arch/arm/lib/Makefile       |    2 +
> >>  arch/arm/lib/syslib.c       |   69 +++++++++++++++++++++++++++++++++++++++++++
> >>  4 files changed, 71 insertions(+), 71 deletions(-)
> >>  delete mode 100644 arch/arm/cpu/armv7/syslib.c
> >>  create mode 100644 arch/arm/lib/syslib.c
> > 
> > Checkpatch says:
> > 
> > total: 2 errors, 0 warnings, 85 lines checked
> > 
> > Please clean up and resubmit.  Thanks.
> 
> mmhhh..I do not know if this is correct. The patch is really only a "git
> mv", an the original files are only moved. If I run checkpatch, I see:

No, it's NOT a mv, it's a remove + add.  The patch was not correctly
formatted.  This should be fixed, then!

> ERROR: spaces required around that ':' (ctx:VxV)
> #164: FILE: arch/arm/lib/syslib.c:37:
> +			  "bne 1b":"=r" (loops):"0"(loops));
>  			          ^
> 
> ERROR: spaces required around that ':' (ctx:VxV)
> #164: FILE: arch/arm/lib/syslib.c:37:
> +			  "bne 1b":"=r" (loops):"0"(loops));
>  			                       ^
> 
> total: 2 errors, 0 warnings, 85 lines checked
> 
> This is an assembly inline - are we sure we apply the same rules for C
> and assembly ?

Guess you are right here. Sorry.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Doubt is a pain too lonely to know that faith is his twin brother.
- Kahlil Gibran