[U-Boot] [PATCH 2/2] mpc85xx: support for Freescale COM Express P2020

[Wolfgang Denk]

Dear "Ira W. Snyder",

In message <20111006230624.GB27124 at ovro.caltech.edu> you wrote:
>
> > > Signed-off-by: Ira W. Snyder <iws at ovro.caltech.edu>
> > > ---
> > >  arch/powerpc/include/asm/immap_85xx.h |    1 +
> > >  board/freescale/p2020come/Makefile    |   53 +++
> > >  board/freescale/p2020come/ddr.c       |  245 +++++++++++++
> > >  board/freescale/p2020come/law.c       |   36 ++
> > >  board/freescale/p2020come/p2020come.c |  393 ++++++++++++++++++++
> > >  board/freescale/p2020come/pci.c       |   43 +++
> > >  board/freescale/p2020come/tlb.c       |   91 +++++
> > >  boards.cfg                            |    3 +
> > >  include/configs/P2020COME.h           |  638 +++++++++++++++++++++++++++++++++
> > >  9 files changed, 1503 insertions(+), 0 deletions(-)
> > >  create mode 100644 board/freescale/p2020come/Makefile
> > >  create mode 100644 board/freescale/p2020come/ddr.c
> > >  create mode 100644 board/freescale/p2020come/law.c
> > >  create mode 100644 board/freescale/p2020come/p2020come.c
> > >  create mode 100644 board/freescale/p2020come/pci.c
> > >  create mode 100644 board/freescale/p2020come/tlb.c
> > >  create mode 100644 include/configs/P2020COME.h

BTW - it appears that an entry to MAINTAINERS is missing as well.


> > Checkpatch says:
> > 
> > total: 6 errors, 23 warnings, 1515 lines checked
> > 
> > Please clean up and resubmit.  Thanks.
> 
> What version of checkpatch do you use? I get 6 errors, 27 warnings with

Checkpatch itself says Version: 0.31; this is not current any more,
indeed.

> the checkpatch from Linux v3.1-rc9-12-g6367f17. I wonder if you have a
> version specific for U-Boot which removes the Linux-specific warnings,
> such as:

I have been hoping somebody else would address this...

> Also, are we now enforcing strict 80 character limits in
> include/configs? I ran this patch through checkpatch before sending it

This is not new.  The 80 char limitation has always been in place,
right from the start.

> to the mailing list. Everything it flagged is either an 80 char limit in
> a configuration file, copied from the corresponding files in the
> boards/freescale/p1_p2_rdb directory, or obviously Linux-specific.

Not really.  Yes, the "line over 80 characters" warnings need fixing.
In addition I think at least these should be addressed:

WARNING: externs should be avoided in .c files
#838: FILE: board/freescale/p2020come/p2020come.c:355:
+extern void ft_pci_board_setup(void *blob);

WARNING: externs should be avoided in .c files
#870: FILE: board/freescale/p2020come/p2020come.c:387:
+extern void cpu_mp_lmb_reserve(struct lmb *lmb);

WARNING: please, no spaces at the start of a line
#1252: FILE: include/configs/P2020COME.h:210:
+    defined(CONFIG_RAMBOOT_SPIFLASH)$


For these I'm not sure - should these not be enclosed in apostophes?

ERROR: need consistent spacing around '/' (ctx:WxV)
#1584: FILE: include/configs/P2020COME.h:542:
+#define CONFIG_ROOTPATH                /opt/nfsroot
                                        ^

ERROR: Macros with complex values should be enclosed in parenthesis
#1584: FILE: include/configs/P2020COME.h:542:
+#define CONFIG_ROOTPATH                /opt/nfsroot

ERROR: Macros with complex values should be enclosed in parenthesis
#1586: FILE: include/configs/P2020COME.h:544:
+#define CONFIG_UBOOTPATH       u-boot.bin


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Live long and prosper.
	-- Spock, "Amok Time", stardate 3372.7