[U-Boot] [PATCH] mvgbe: fix network device indices

Mike Frysinger vapier at gentoo.org
Fri Oct 7 19:16:24 CEST 2011


On Thursday 06 October 2011 18:23:22 Michael Walle wrote:
> --- a/net/eth.c
> +++ b/net/eth.c
> 
> +int eth_setenv_enetaddr_by_index(const char *base_name, int index,
> +				 const uchar *enetaddr)
> +{
> +	char enetvar[32];
> +	sprintf(enetvar, index ? "%s%daddr" : "%saddr", base_name, index);
> +	return eth_setenv_enetaddr(enetvar, enetaddr);
> +}

please unify the duplicate logic coming from eth_getenv_enetaddr_by_index in a 
new local static function
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20111007/9420fe8d/attachment.pgp 


More information about the U-Boot mailing list