[U-Boot] [PATCH v2] netconsole: support packets longer than 512 bytes

Michael Walle michael at walle.cc
Sat Oct 8 01:22:22 CEST 2011


Am Samstag 08 Oktober 2011, 00:53:13 schrieb Mike Frysinger:
> On Friday 07 October 2011 18:27:50 Michael Walle wrote:
> > Esp. while printing the environment the output is usually longer than 512
> > bytes. Instead of cutting the message, send multiple 512 bytes packets.
> 
> sorry, i probably should have looked closer earlier.  this isn't really
> your fault, but i'm guessing this 512 limit is due to the size of the
> static input_buffer ?  if so, let's use sizeof(input_buffer) instead of
> 512.  or add a define at the top like NETCONSOLE_BUFFER_SIZE and use that
> everywhere. -mike

i don't think the input buffer has sth to do with the output. of course it 
could be intended, that the input buffer has the same size as the max output 
size. if i didn't miss sth, the output size is only limited by the maximum 
packet size (minus headers) defined by PKTSIZE.

I don't know why the input buffer and max output size has this particular 
size. Well, the input buffer could be some arbitrary number to. not too big to 
save some space :)

The max output size should be PKTSIZE-NetEthHdrSize()-IP_HDR_SIZE.

-- 
Michael


More information about the U-Boot mailing list