[U-Boot] [PATCH 5/6] da850: add support to read mac address from spi flash

Hadli, Manjunath manjunath.hadli at ti.com
Sat Oct 8 11:08:59 CEST 2011


Mike,
 
On Fri, Sep 30, 2011 at 21:21:34, Mike Frysinger wrote:
> On Friday, September 30, 2011 07:24:26 nagabhushana.netagunte at ti.com wrote:
> > +		if (is_multicast_ether_addr(buff) ||
> > +				is_zero_ether_addr(buff)) {
> 
> NAK: use is_valid_ether_addr()
Thanks. Changed this.
> 
> > +		sprintf((char *)enetaddr, "%pM", buff);
> > +
> > +		eth_setenv_enetaddr("ethaddr", enetaddr);
> 
> NAK: eth_setenv_enetaddr() does the sprintf for you -mike
Thanks Mike. I have removed the sprintf.
> 

Also, 
I will be taking care of the patch set from now. I will resubmit the patches with the changes.

Thx,
-Manju



More information about the U-Boot mailing list